scripts/image-fixes/20-Rubric-anchors.stRubEditingAreaTest>>testEmbeddedAnchorInTextAreDrawn, RubEditingAreaTest>>testEmbeddedAnchorInTextAreDrawnAtRightPosition, RubScrolledTextMorphTest>>testEmbeddedAnchorInTextAreDrawnAtRightPositionAll three tests were disabled by a leftover "self skip" line with a comment "fails in CI". With the skip removed, the tests pass unchanged on both VMs, so the CI failure no longer occurs; the old CI failure was not investigated. The fix file replaces the three test methods with their original source minus the skip line. No assertion was changed.
| Test | Defect in | State | Cause |
|---|---|---|---|
RubEditingAreaTest>>testEmbeddedAnchorInTextAreDrawn |
test | repaired | Test starts with 'self skip' (stale CI workaround); without it the test passes |
RubEditingAreaTest>>testEmbeddedAnchorInTextAreDrawnAtRightPosition |
test | repaired | Test starts with 'self skip' (stale CI workaround); without it the test passes |
RubScrolledTextMorphTest>>testEmbeddedAnchorInTextAreDrawnAtRightPosition |
test | repaired | Test starts with 'self skip' (stale CI workaround); without it the test passes |
Regression check: Whole classes RubEditingAreaTest and RubScrolledTextMorphTest, on ours (JIT) and Cog, before and after the fix. RubEditingAreaTest: 5 PASS + 2 SKIP before, 7 PASS after, on both VMs. RubScrolledTextMorphTest: 1 PASS + 1 SKIP before, 2 PASS after, on both VMs. No non-test methods were changed. The ours-nojit mode was not run.
Upstream note: Pharo: Rubric-Tests, re-enable the three embedded-anchor tests. RubEditingAreaTest>>testEmbeddedAnchorInTextAreDrawn, RubEditingAreaTest>>testEmbeddedAnchorInTextAreDrawnAtRightPosition and RubScrolledTextMorphTest>>testEmbeddedAnchorInTextAreDrawnAtRightPosition begin with 'self skip' and a 'fails in CI' comment. Removing the skip makes them pass on Pharo 14 build 791 on stock Cog v12.0.6 arm64 (and on our VM) when run headless with a fake Display. Proposal: delete the skip lines and watch CI; the old CI failure was not reproduced or investigated here.
Last full sweeps of 2026-11-17: iospharo (sweep14-new14) and stock Cog with the Cog changes (sweepcogp14-new10), with all image fixes. "Before" is the state of the test before the repairs. The Stock Cog column has a value only where the record measured stock Cog: "PASS 3 of 3 (repair run)" is the check of each repair on stock Cog v12.0.6 with the fix entry; "-" is not measured separately.
| Test | Before | State | iospharo VM | Patched Cog | Stock Cog |
|---|---|---|---|---|---|
RubEditingAreaTest>>testEmbeddedAnchorInTextAreDrawn | SKIP | repaired | PASS | PASS | PASS 3 of 3 (repair run) |
RubEditingAreaTest>>testEmbeddedAnchorInTextAreDrawnAtRightPosition | SKIP | repaired | PASS | PASS | PASS 3 of 3 (repair run) |
RubScrolledTextMorphTest>>testEmbeddedAnchorInTextAreDrawnAtRightPosition | SKIP | repaired | PASS | PASS | PASS 3 of 3 (repair run) |
Run the tests in a Pharo 14 image (build 791). Before the fix they skip, fail or carry the expected-failure mark.
"Run in a Playground of a Pharo 14 image (Do it and print each line)." ((RubEditingAreaTest selector: #testEmbeddedAnchorInTextAreDrawn) run) printString. ((RubEditingAreaTest selector: #testEmbeddedAnchorInTextAreDrawnAtRightPosition) run) printString. ((RubScrolledTextMorphTest selector: #testEmbeddedAnchorInTextAreDrawnAtRightPosition) run) printString.
testEmbeddedAnchorInTextAreDrawn
| circle text canvas|
self skip. "Somehow this test fails in the CI"
circle := CircleMorph new extent: 50 @ 50;color: Color blue.
self assert: circle owner isNil.
self assert: circle position equals: 0@0.
"add the circle to a text string"
text := ('aaaaa',(String value: 1),'bbbbbbb') asText
addAttribute: (TextAnchor new anchoredMorph: circle).
"render the text in a RubEditingArea to place the circle in a layout"
area updateTextWith: text.
canvas := FormCanvas extent: 500@500.
canvas fullDrawMorph: area.
self assert: (circle hasProperty: #hasBeenPositioned).
self deny: circle position equals: 0@0testEmbeddedAnchorInTextAreDrawnAtRightPosition | circle longTextWithCircleAtEnd canvas| self skip. "The test fails in CI" circle := CircleMorphCounter new extent: 50 @ 50;color: Color blue. longTextWithCircleAtEnd := ((String loremIpsum: 10000), (String value: 1)) asText addAttribute: (TextAnchor new anchoredMorph: circle). self assert: circle owner isNil. self assert: circle position equals: 0@0. self assert: circle counter equals: 0. area updateTextWith: longTextWithCircleAtEnd. canvas := FormCanvas extent: 500@500. canvas fullDrawMorph: area. self assert: circle counter equals: 1. self assert: circle position y > 500
testEmbeddedAnchorInTextAreDrawnAtRightPosition | circle longTextWithCircleAtEnd canvas| self skip. "Test fail in CI" circle := CircleMorphCounter new extent: 50 @ 50;color: Color blue. longTextWithCircleAtEnd := ((String loremIpsum: 10000), (String value: 1)) asText addAttribute: (TextAnchor new anchoredMorph: circle). self assert: circle owner isNil. self assert: circle position equals: 0@0. morph updateTextWith: longTextWithCircleAtEnd. canvas := FormCanvas extent: 500@500. canvas fullDrawMorph: morph. self assert: circle owner equals: nil. self assert: circle counter equals: 0. morph scrollToEndOfText. canvas := FormCanvas extent: 500@500. canvas fullDrawMorph: morph. self assert: circle counter > 0
How to apply an entries file: file in 00-header.st and the entries file as one chunk (the iospharo script scripts/gen-image-fixes.py makes that chunk). Each entry checks for the defect first and prints FIXED, ADDED or SKIP. Download 00-header.st.
fix value: #RubEditingAreaTest value: #testEmbeddedAnchorInTextAreDrawn
value: [ :source | source includesSubstring: 'self skip' ]
value:
'testEmbeddedAnchorInTextAreDrawn
| circle text canvas|
circle := CircleMorph new extent: 50 @ 50;color: Color blue.
self assert: circle owner isNil.
self assert: circle position equals: 0@0.
"add the circle to a text string"
text := (''aaaaa'',(String value: 1),''bbbbbbb'') asText
addAttribute: (TextAnchor new anchoredMorph: circle).
"render the text in a RubEditingArea to place the circle in a layout"
area updateTextWith: text.
canvas := FormCanvas extent: 500@500.
canvas fullDrawMorph: area.
self assert: (circle hasProperty: #hasBeenPositioned).
self deny: circle position equals: 0@0'.
fix value: #RubEditingAreaTest value: #testEmbeddedAnchorInTextAreDrawnAtRightPosition
value: [ :source | source includesSubstring: 'self skip' ]
value:
'testEmbeddedAnchorInTextAreDrawnAtRightPosition
| circle longTextWithCircleAtEnd canvas|
circle := CircleMorphCounter new extent: 50 @ 50;color: Color blue.
longTextWithCircleAtEnd := ((String loremIpsum: 10000),
(String value: 1)) asText
addAttribute: (TextAnchor new anchoredMorph: circle).
self assert: circle owner isNil.
self assert: circle position equals: 0@0.
self assert: circle counter equals: 0.
area updateTextWith: longTextWithCircleAtEnd.
canvas := FormCanvas extent: 500@500.
canvas fullDrawMorph: area.
self assert: circle counter equals: 1.
self assert: circle position y > 500'.
fix value: #RubScrolledTextMorphTest value: #testEmbeddedAnchorInTextAreDrawnAtRightPosition
value: [ :source | source includesSubstring: 'self skip' ]
value:
'testEmbeddedAnchorInTextAreDrawnAtRightPosition
| circle longTextWithCircleAtEnd canvas|
circle := CircleMorphCounter new extent: 50 @ 50;color: Color blue.
longTextWithCircleAtEnd := ((String loremIpsum: 10000),
(String value: 1)) asText
addAttribute: (TextAnchor new anchoredMorph: circle).
self assert: circle owner isNil.
self assert: circle position equals: 0@0.
morph updateTextWith: longTextWithCircleAtEnd.
canvas := FormCanvas extent: 500@500.
canvas fullDrawMorph: morph.
self assert: circle owner equals: nil.
self assert: circle counter equals: 0.
morph scrollToEndOfText.
canvas := FormCanvas extent: 500@500.
canvas fullDrawMorph: morph.
self assert: circle counter > 0'.
State of 2026-11-20. Made from the test records of the iospharo project (a second Pharo VM). The fixes are proposals for review.