Pharo test defects

StSettingsBrowserTest

State
Fixed (image fix)
Defect in
the test
Tests
1
Fix
image fix 20-StSettingsBrowserTest.st
Upstream repository
pharo-spec/NewTools

Record

testSimulateCategoryPopulation began with "self skip", and its body was stale. It called categoriesPresenter categoryListPresenter, which no longer exists: categoriesPresenter is now a SpEasyTreeListViewPresenter (a tree). It then looked up a presenter #settingsBox in the details presenter, and that name no longer exists either. Un-skipped, the original body fails with a MessageNotUnderstood for #categoryListPresenter on both VMs. The fix rewrites the test for the current API: it selects the first root category of the tree and asserts that the details presenter model is that category. It then asserts that the details presenter replaced its placeholder label with a presenter whose layout has children. The skip is removed and no assertion is weakened.

Test Defect in State Cause
StSettingsBrowserTest>>testSimulateCategoryPopulation test repaired The test body is stale after a Spec2 refactor (categoryListPresenter and #settingsBox are gone), and it was parked with self skip.

Regression check: I ran the whole StSettingsBrowserTest class on both VMs, with and without the fix. Ours: 17 PASS before, 18 PASS with the fix. Cog: 17 PASS before, 18 PASS with the fix. No other test class was run, because the only method changed is this test method.

Upstream note: Title: Repair StSettingsBrowserTest>>testSimulateCategoryPopulation (project: Pharo). Description: The test was disabled with self skip, and its body used presenters that no longer exist (categoryListPresenter, #settingsBox). The rewritten test selects the first root of the categories tree list and checks two things. First, the details presenter model is that category. Second, the placeholder label has been replaced by a presenter whose layout has children. This has not been submitted anywhere. The owner must review it first.

Results

Last full sweeps of 2026-11-17: iospharo (sweep14-new14) and stock Cog with the Cog changes (sweepcogp14-new10), with all image fixes. "Before" is the state of the test before the repairs. The Stock Cog column has a value only where the record measured stock Cog: "PASS 3 of 3 (repair run)" is the check of each repair on stock Cog v12.0.6 with the fix entry; "-" is not measured separately.

TestBeforeStateiospharo VMPatched CogStock Cog
StSettingsBrowserTest>>testSimulateCategoryPopulationSKIPrepairedPASSPASSPASS 3 of 3 (repair run)

Test

Run the tests in a Pharo 14 image (build 791). Before the fix they skip, fail or carry the expected-failure mark.

"Run in a Playground of a Pharo 14 image (Do it and print each line)."
((StSettingsBrowserTest selector: #testSimulateCategoryPopulation) run) printString.

Source of the tests before the fix

StSettingsBrowserTest>>testSimulateCategoryPopulation before the fix (Pharo 14 build 791)
testSimulateCategoryPopulation

	| childSettingsLayout |
	
	self skip.
	categoriesPresenter categoryListPresenter clickItem: 1.
	childSettingsLayout := detailsPresenter presenterAt: #settingsBox.
		
	"(Delay forSeconds: 5) wait." 
	self
		assert: childSettingsLayout children notEmpty
		description: 'It tests that after a category selection has been made, the details presenter contains a title'

Fix

How to apply an entries file: file in 00-header.st and the entries file as one chunk (the iospharo script scripts/gen-image-fixes.py makes that chunk). Each entry checks for the defect first and prints FIXED, ADDED or SKIP. Download 00-header.st.

20-StSettingsBrowserTest.st (download)
fix value: #StSettingsBrowserTest value: #testSimulateCategoryPopulation
	value: [ :s | s includesSubstring: 'self skip' ]
	value: 'testSimulateCategoryPopulation

	| firstCategory shownSettings |
	firstCategory := categoriesPresenter roots first.
	categoriesPresenter selectItem: firstCategory.
	self
		assert: detailsPresenter model
		identicalTo: firstCategory.
	"the details presenter replaced its placeholder label by the presenter of the category"
	shownSettings := detailsPresenter presenters first.
	self deny: (shownSettings isKindOf: SpLabelPresenter).
	self
		assert: shownSettings layout children notEmpty
		description: ''It tests that after a category selection has been made, the details presenter contains the settings of the category'''.

State of 2026-11-20. Made from the test records of the iospharo project (a second Pharo VM). The fixes are proposals for review.