The record is the text of the repair. The Results table is the last run of the row.
Buoy-Metaprogramming-Pharo-Extensions has an
extension Symbol>>argumentCount ^ self numArgs. Pharo 14 has its own
Symbol>>argumentCount ^ self numArgs + 1 (the receiver is the first
argument when a symbol stands for a block), and
Symbol>>valueWithEnoughArguments: depends on that value. The load of
Buoy replaces the method of the image.valueWithEnoughArguments:. With the method of Buoy the argument array is
empty, and the load stops with SubscriptOutOfBounds: 1 in #(). Each
later use of a symbol as a block in the image has the same defect.patches/ba-st-buoy.patch removes the extension and changes the
one sender in Buoy (KeywordMessageSendingCollector) to numArgs.OrderedDictionaryExtensionsTest>>testEquals is a copy of
an old test of Pharo. It fills two dictionaries in opposite orders and
expects that the two are equal. OrderedDictionary>>= of Pharo 14
compares the index of each key, so the order matters. The test of Pharo
14 itself fills the two in the same order.fixes/ba-st-buoy.st gives the test the form of the Pharo 14
test, with one more check that the opposite order is not equal.ba-st/Launchpad (row 14) and ba-st/Hyperspace (row 15) stopped in the
load with SubscriptOutOfBounds: 1 in #(). The files
locks/ba-st-launchpad.txt and locks/ba-st-hyperspace.txt make the load
take Buoy from a local clone with the patch (a Metacello lock).Load the package into a Pharo 14 image (build 791) with the load expression of the test run, file in the fixes file of the row if there is one, and run the test classes of the package.
"row 10"
Metacello new baseline: 'Buoy'; repository: 'github://ba-st/Buoy:release-candidate/source'; onConflict: [:e | e useIncoming]; load: #('default' 'CI').Last result of the package run (stock Cog and iospharo on the same image).
| Row | Label | Load | Stock Cog | iospharo VM |
|---|---|---|---|---|
| 10 | ba-st-buoy | ok | tests=616 P=616 F=0 E=0 S=0 T=0 X=0 | tests=616 P=616 F=0 E=0 S=0 T=0 X=0 |
"Buoy (ba-st/Buoy, release-candidate): OrderedDictionaryExtensionsTest>>testEquals
is a copy of an old OrderedDictionaryTest>>testEquals of Pharo. It fills two
dictionaries with the same associations in opposite orders and expects that
the two are equal ('For equality, order will not matter').
OrderedDictionary>>= of Pharo 14 compares indexOfKey: for each key, so the
order matters. The test of Pharo 14 itself (OrderedDictionaryTest>>testEquals)
fills the two dictionaries in the same order. The test of Buoy fails on stock
Cog and on our VM with 'Got an OrderedDictionary(...) instead of an
OrderedDictionary(...)'.
The repair: the two dictionaries get the associations in the same order, as in
the test of Pharo 14, and a third dictionary with the opposite order must not
be equal."
fix value: #OrderedDictionaryExtensionsTest value: #testEquals
value: [ :source | source includesSubstring: 'with: self orderedAssociations reversed' ]
value:
'testEquals
| dictionaryOne dictionaryTwo dictionaryThree |
dictionaryOne := self emptyDictionary.
dictionaryTwo := self emptyDictionary.
self
assertDictionary: dictionaryOne
equals: dictionaryTwo.
"Pharo 14: the order of the associations matters for equality"
self orderedAssociations
with: self orderedAssociations
do: [:firstAssociation :secondAssociation |
dictionaryOne add: firstAssociation.
dictionaryTwo add: secondAssociation.
self
assertDictionary: dictionaryOne
doesNotEqual: self emptyDictionary.
self
assertDictionary: dictionaryTwo
doesNotEqual: self emptyDictionary.
self
assertDictionary: dictionaryOne
equals: dictionaryTwo].
"The same associations in the opposite order are not equal"
dictionaryThree := self emptyDictionary.
self orderedAssociations reversed do: [:each | dictionaryThree add: each].
self assert: dictionaryThree size equals: dictionaryOne size.
self
assertDictionary: dictionaryOne
doesNotEqual: dictionaryThree.
self
assertDictionary: dictionaryOne
equals: dictionaryTwo'.
diff --git a/source/Buoy-Metaprogramming-Pharo-Extensions/Symbol.extension.st b/source/Buoy-Metaprogramming-Pharo-Extensions/Symbol.extension.st
deleted file mode 100644
index e652fd1..0000000
--- a/source/Buoy-Metaprogramming-Pharo-Extensions/Symbol.extension.st
+++ /dev/null
@@ -1,7 +0,0 @@
-Extension { #name : 'Symbol' }
-
-{ #category : '*Buoy-Metaprogramming-Pharo-Extensions' }
-Symbol >> argumentCount [
-
- ^self numArgs
-]
diff --git a/source/Buoy-Metaprogramming/KeywordMessageSendingCollector.class.st b/source/Buoy-Metaprogramming/KeywordMessageSendingCollector.class.st
index 5e9bbb1..e60779c 100644
--- a/source/Buoy-Metaprogramming/KeywordMessageSendingCollector.class.st
+++ b/source/Buoy-Metaprogramming/KeywordMessageSendingCollector.class.st
@@ -23,7 +23,7 @@ KeywordMessageSendingCollector class >> sendingAllMessagesBeginningWith: aPrefix
KeywordMessageSendingCollector class >> sendingAllMessagesMatching: aFilterBlock to: aReceiver withAll: anArgumentCollection [
^ self new
- initializeSendingAllMessagesMatching: [ :selector | selector argumentCount = anArgumentCollection size and: [ aFilterBlock value: selector ] ]
+ initializeSendingAllMessagesMatching: [ :selector | selector numArgs = anArgumentCollection size and: [ aFilterBlock value: selector ] ]
to: aReceiver
withAll: anArgumentCollection asArray
]
# Buoy replaces Symbol>>argumentCount of Pharo 14, and the load stops (docs/upstream/package-repairs.md). Buoy ba-st-buoy
# Buoy replaces Symbol>>argumentCount of Pharo 14, and the load stops (docs/upstream/package-repairs.md). Buoy ba-st-buoy
State of 2026-11-20. Made from the test records of the iospharo project (a second Pharo VM). The fixes are proposals for review.