Pharo test defects

Package: P3 (svenvc/P3, row 113)

State
Open: 73 tests, a decision of the owner
Defect in
see the record
Tests
73
Fix
svenvc-p3.st
Upstream repository
svenvc/P3

The record is the text of the repair. The Results table is the last run of the row.

Record

Test

Load the package into a Pharo 14 image (build 791) with the load expression of the test run, file in the fixes file of the row if there is one, and run the test classes of the package.

"row 113"
Metacello new baseline: 'P3'; repository: 'github://svenvc/P3'; onConflict: [:e | e useIncoming]; load: #('default').

Results

Last result of the package run (stock Cog and iospharo on the same image).

RowLabelLoadStock Cogiospharo VM
113svenvc-p3oktests=96 P=23 F=0 E=70 S=0 T=3 X=0tests=96 P=23 F=0 E=70 S=0 T=3 X=0

Tests that do not pass

TestStock Cogiospharo VM
P3ClientTest>>testArrayTypesERRORERROR
P3ClientTest>>testBitStringConversionERRORERROR
P3ClientTest>>testBooleanConversionERRORERROR
P3ClientTest>>testBoxConversionERRORERROR
P3ClientTest>>testByteArrayConversionERRORERROR
P3ClientTest>>testChronologyERRORERROR
P3ClientTest>>testChronologyWithTimezoneERRORERROR
P3ClientTest>>testCircleConversionERRORERROR
P3ClientTest>>testConnectionERRORERROR
P3ClientTest>>testConstraintsERRORERROR
P3ClientTest>>testConvenienceMetaAccessERRORERROR
P3ClientTest>>testCustomCompositeTypeERRORERROR
P3ClientTest>>testEmptyStringERRORERROR
P3ClientTest>>testEnumERRORERROR
P3ClientTest>>testErrorERRORERROR
P3ClientTest>>testIntegerConversionERRORERROR
P3ClientTest>>testIntegerVectorERRORERROR
P3ClientTest>>testIntervalConversionERRORERROR
P3ClientTest>>testJsonConversionERRORERROR
P3ClientTest>>testLineConversionERRORERROR
P3ClientTest>>testLineSegmentConversionERRORERROR
P3ClientTest>>testMultiStatementERRORERROR
P3ClientTest>>testMultipleCommandsInOneRequestERRORERROR
P3ClientTest>>testNonAsciiStringsERRORERROR
P3ClientTest>>testNotificationERRORERROR
P3ClientTest>>testPathConversionERRORERROR
P3ClientTest>>testPointConversionERRORERROR
P3ClientTest>>testPolygonConversionERRORERROR
P3ClientTest>>testQueryCatalogERRORERROR
P3ClientTest>>testSessionERRORERROR
P3ClientTest>>testSimpleTableERRORERROR
P3ClientTest>>testSqlFunctionERRORERROR
P3ClientTest>>testStringEscapingERRORERROR
P3ClientTest>>testTimeConversionERRORERROR
P3ClientTest>>testTimeoutERRORERROR
P3ClientTest>>testTimezoneERRORERROR
P3ClientTest>>testTimezoneZTimestampERRORERROR
P3ClientTest>>testUuidERRORERROR
P3ClientTest>>testValuesArray1ERRORERROR
P3ClientTest>>testValuesArray2ERRORERROR
P3ClientTest>>testZTimestampERRORERROR
P3ClientTest>>testZTimestampWithTimezoneERRORERROR
P3ConnectionPoolTest>>testErrorTIMEOUTTIMEOUT
P3ConnectionPoolTest>>testOneTIMEOUTTIMEOUT
P3ConnectionPoolTest>>testWarmUpTIMEOUTTIMEOUT
P3FormattedStatementTest>>testBitStringERRORERROR
P3FormattedStatementTest>>testByteArrayERRORERROR
P3FormattedStatementTest>>testChronologyERRORERROR
P3FormattedStatementTest>>testChronologyWithTimezoneERRORERROR
P3FormattedStatementTest>>testGeometricTypesERRORERROR
P3FormattedStatementTest>>testInClauseERRORERROR
P3FormattedStatementTest>>testIntervalERRORERROR
P3FormattedStatementTest>>testNullERRORERROR
P3FormattedStatementTest>>testPrintOnERRORERROR
P3FormattedStatementTest>>testSimpleERRORERROR
P3FormattedStatementTest>>testStringsERRORERROR
P3PreparedStatementTest>>testBatchInsertStatementERRORERROR
P3PreparedStatementTest>>testBinaryColumnERRORERROR
P3PreparedStatementTest>>testBitStringERRORERROR
P3PreparedStatementTest>>testBulkInsertAndSelectERRORERROR
P3PreparedStatementTest>>testChronologyERRORERROR
P3PreparedStatementTest>>testChronologyWithTimezoneERRORERROR
P3PreparedStatementTest>>testChronologyZTimestampERRORERROR
P3PreparedStatementTest>>testGeometricTypesERRORERROR
P3PreparedStatementTest>>testInClauseERRORERROR
P3PreparedStatementTest>>testInsertNullERRORERROR
P3PreparedStatementTest>>testIntervalERRORERROR
P3PreparedStatementTest>>testLongQueriesERRORERROR
P3PreparedStatementTest>>testMultipleInsertStatementsERRORERROR
P3PreparedStatementTest>>testNamedPreparedStatementERRORERROR
P3PreparedStatementTest>>testScaledDecimalERRORERROR
P3PreparedStatementTest>>testSelectStatementERRORERROR
P3PreparedStatementTest>>testSimpleInsertStatementERRORERROR

Fix

Fixes file (filed in after the load): svenvc-p3.st (download)
"svenvc/P3: P3Client>>retryDelay: ignored its argument.  The method stored the
constant 5 (settings at: #retryDelay put: 5), so a caller that sets another
delay still waits 5 seconds between reconnection tries.  P3ClientTest>>testTimeout
calls retryDelay: 0 to have no wait, and a pool query on an unreachable host
(P3ConnectionPoolTest, 10 tries of 5 seconds) cannot be shortened either.  The
repair stores the argument."

fix value: #P3Client value: #retryDelay:
	value: [ :source | source includesSubstring: 'put: 5' ]
	value:
'retryDelay: seconds
	"Set the delay after which a reconnection will be tried on a failed connection, the default being 5 seconds.
	See also #retryCount:"

	settings at: #retryDelay put: seconds'.

State of 2026-11-20. Made from the test records of the iospharo project (a second Pharo VM). The fixes are proposals for review.