Pharo test defects

Package: pharo-dataset (pharo-llm/pharo-dataset, row 143)

State
Fixed (package repair)
Defect in
see the record
Tests
0
Fix
pharo-llm-pharo-dataset.st
Upstream repository
pharo-llm/pharo-dataset

The record is the text of the repair. The Results table is the last run of the row.

Record

Test

Load the package into a Pharo 14 image (build 791) with the load expression of the test run, file in the fixes file of the row if there is one, and run the test classes of the package.

"row 143"
Metacello new baseline: 'HeuristicCompletionGenerator'; repository: 'github://pharo-llm/pharo-dataset:main/src'; onConflict: [:e | e useIncoming]; load.

Results

Last result of the package run (stock Cog and iospharo on the same image).

RowLabelLoadStock Cogiospharo VM
143pharo-llm-pharo-datasetoktests=14 P=14 F=0 E=0 S=0 T=0 X=0tests=14 P=14 F=0 E=0 S=0 T=0 X=0

Fix

Fixes file (filed in after the load): pharo-llm-pharo-dataset.st (download)
"pharo-llm/pharo-dataset: commit ff24157 of the package removed the method
CooCompletionDatasetExporter>>entriesAsCompletionJsonString (the JSON array
form of the entries) when the JSONL methods were rewritten.  The commit kept
two callers (writeToFileNamed: and writeToFileReference:) and the test
CooCompletionDatasetExporterTest>>testEntriesAsJsonStringSerializesEntries,
so the test and the two callers fail with doesNotUnderstand on every VM.
The repair restores the method with the body that the commit removed, but
reads filteredEntries (as the other entriesAs... methods now do) so that a
quality filter applies.  No test sends a request to a network service or reads
the environment."

add value: #CooCompletionDatasetExporter value: #entriesAsCompletionJsonString
	value: 'accessing'
	value:
'entriesAsCompletionJsonString

	^ NeoJSONWriter toString: (self filteredEntries collect: [ :entry |
		   Dictionary new
			   at: ''context'' put: (entry at: #context);
			   at: ''candidates'' put: (entry at: #candidates);
			   at: ''fetchers'' put: (entry at: #fetchers);
			   at: ''correct'' put: (entry at: #correct);
			   yourself ])'.

State of 2026-11-20. Made from the test records of the iospharo project (a second Pharo VM). The fixes are proposals for review.