The record is the text of the repair. The Results table is the last run of the row.
LOAD-FAIL (UndeclaredVariableRead of
RPackageOrganizer in BaselineOfPharoEnhancements>>isGTImage).RPackageOrganizer, which Pharo 12 and
later do not have.TraitBuilderEnhancer.extension.st replaces two methods of the image
with copies of an older Pharo. The copy of allSlotsForBuilder: leaves
the slots of the superclass out. Pharo 14 builds each class with that
method, so a load of the file breaks the build of classes after it.patches/seandenigris-pharo-enhancements.patch, for the owner of
the package): the baseline uses PackageOrganizer default, and the
extension file of TraitBuilderEnhancer is gone (no code of the package
uses its two methods).Load the package into a Pharo 14 image (build 791) with the load expression of the test run, file in the fixes file of the row if there is one, and run the test classes of the package.
"row 149"
Metacello new baseline: 'PharoEnhancements'; repository: 'github://seandenigris/Pharo-Enhancements:master/src'; onConflict: [:e | e useIncoming]; load: #('default').Last result of the package run (stock Cog and iospharo on the same image).
| Row | Label | Load | Stock Cog | iospharo VM |
|---|---|---|---|---|
| 149 | seandenigris-pharo-enhancements | ok | tests=4 P=4 F=0 E=0 S=0 T=0 X=0 | tests=4 P=4 F=0 E=0 S=0 T=0 X=0 |
diff --git a/src/BaselineOfPharoEnhancements/BaselineOfPharoEnhancements.class.st b/src/BaselineOfPharoEnhancements/BaselineOfPharoEnhancements.class.st
index 346bf79..c71402f 100644
--- a/src/BaselineOfPharoEnhancements/BaselineOfPharoEnhancements.class.st
+++ b/src/BaselineOfPharoEnhancements/BaselineOfPharoEnhancements.class.st
@@ -39,6 +39,6 @@ BaselineOfPharoEnhancements >> customProjectAttributes [
{ #category : #testing }
BaselineOfPharoEnhancements >> isGTImage [
- ^ RPackageOrganizer default packageNames anySatisfy: [ :pn | pn beginsWith: 'Lepiter-' ].
+ ^ PackageOrganizer default packageNames anySatisfy: [ :pn | pn beginsWith: 'Lepiter-' ].
"Implementation note: used to check for GToolkit prefix, but P7 has a GToolkit-Examples package. Lepiter, OTOH, could only be loaded in a GT image"
]
diff --git a/src/PharoEnhancements/TraitBuilderEnhancer.extension.st b/src/PharoEnhancements/TraitBuilderEnhancer.extension.st
deleted file mode 100644
index eb30e39..0000000
--- a/src/PharoEnhancements/TraitBuilderEnhancer.extension.st
+++ /dev/null
@@ -1,23 +0,0 @@
-Extension { #name : 'TraitBuilderEnhancer' }
-
-{ #category : '*PharoEnhancements' }
-TraitBuilderEnhancer >> allSlotsForBuilder: aBuilder [
-
- | resultingSlots |
-
- resultingSlots := self
- eliminateDuplicates: aBuilder layoutDefinition slots , aBuilder traitComposition asTraitComposition slotsCopy
- withSuperclassSlots: (aBuilder superclass ifNil: [#()] ifNotNil:[ :x | x allSlots]).
-
- ^ resultingSlots
-]
-
-{ #category : '*PharoEnhancements' }
-TraitBuilderEnhancer >> configureClass: newClass superclass: superclass withLayoutType: layoutType slots: slots [
- | resultingSlots |
- self validateTraitComposition: self traitComposition ofClass: builder oldClass.
-
- resultingSlots := self allSlotsForBuilder: builder.
-
- newClass superclass: superclass withLayoutType: layoutType slots: resultingSlots
-]
State of 2026-11-20. Made from the test records of the iospharo project (a second Pharo VM). The fixes are proposals for review.